Added Elastic as vector DB to RAG LLM #64
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sauagarwa
requested changes
May 5, 2025
| @@ -88,6 +88,21 @@ spec: | |||
| - name: PGVECTOR_COLLECTION_NAME | |||
| value: {{ .Values.global.db.index }} | |||
| {{- end }} | |||
| {{- if eq .Values.global.db.type "ELASTIC" }} | |||
There was a problem hiding this comment.
Can we externalize all the variables like the username, url index in values.yaml files, so that it can be overridable
There was a problem hiding this comment.
I have parameterized index name . I would prefer to keep url, username "opinionated" for the elastic. Elastic is default user in Elastic cluster, it allows us to benefit from automatically generated secret with credentials instead of creating additional entries to the vault. Alternative user name would require creating this user and explicitly creating RBAC , unnecessary complicating configuration for our demonstration purposes.
| @@ -83,6 +83,21 @@ spec: | |||
| value: 'postgresql+psycopg://$(DB_USERNAME):$(DB_PASS)@$(DB_HOST):$(DB_PORT)/$(DB_NAME)' | |||
| - name: PGVECTOR_COLLECTION_NAME | |||
| value: {{ .Values.global.db.index }} | |||
| {{- end }} | |||
There was a problem hiding this comment.
same here . can we allow the user to override these values from values.yaml
|
/lgtm |
sauagarwa
approved these changes
May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to helm charts to add Elastic as one of the supported vector dbs. Also includes fixes to grafana dashboards to eliminate duplication for some of the tiles